feat: port Wire Android services & use cases - WPB-16148 #2920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e:dataPath:metadata:uploadStatus:)` compile error
Perhaps we can delete these but I will comment them for the time being
It is not clear to me what this TODO means.
# Conflicts: # wire-ios-data-model/Resources/zmessaging.xcdatamodeld/zmessaging2.125.0.xcdatamodel/contents # wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
This commit doesn't contain any new/updated entities - just the new model
samwyndham
reviewed
May 5, 2025
samwyndham
approved these changes
May 5, 2025
samwyndham
requested review from
a team,
netbe,
caldrian and
jullianm
and removed request for
a team,
netbe and
caldrian
jullianm
reviewed
May 5, 2025
...alStore/WireCellsMessageAttachmentsDraftsLocalStore+WireCellsMessageAttachmentDraftDAO.swift
Show resolved
Hide resolved
WireCells/Sources/WireCellsAPI/Persistence/WireCellsMessageAttachmentDraftRepository.swift
Show resolved
Hide resolved
samwyndham
requested review from
jullianm and
dmitrysimkin
and removed request for
dmitrysimkin
dmitrysimkin
reviewed
May 7, 2025
WireCells/Sources/WireCellsAPI/Persistence/WireCellsConversationDAO.swift
Show resolved
Hide resolved
WireCells/Sources/WireCellsAPI/Persistence/WireCellsMessageAttachmentDraftDAO.swift
Show resolved
Hide resolved
WireCells/Sources/WireCellsImplementation/Persistence/WireCellConversationDataSource.swift
Show resolved
Hide resolved
WireCells/Sources/WireCellsImplementation/WireCellsAwsClientImplementation.swift
Show resolved
Hide resolved
jullianm
approved these changes
May 12, 2025
dmitrysimkin
approved these changes
May 15, 2025
# Conflicts: # wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ports and integrates the Android WireCells services & use cases interfaces & implementations to the iOS app.
Remaining
Tests for this PR will be done in a follow up ticket: https://wearezeta.atlassian.net/browse/WPB-17490
Testing
None of this code is used yet so cannot be manually tested
Checklist
[WPB-XXX].